Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowercase mailto:-addresses in getNormalizedValue() #565

Merged
merged 2 commits into from Jun 24, 2022

Conversation

pk1234
Copy link
Contributor

@pk1234 pk1234 commented Feb 20, 2022

so far getNormalizedValue() only lowercased schema-value.
for mailto:-addresses it now lowercases the address as well.

Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

lib/Property/ICalendar/CalAddress.php Outdated Show resolved Hide resolved
@phil-davis phil-davis dismissed DeepDiver1975’s stale review June 24, 2022 10:56

Comment about === was addressed

@phil-davis phil-davis merged commit 5e89cf9 into sabre-io:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants