-
Notifications
You must be signed in to change notification settings - Fork 129
Replace assertRegExp with assertMatchesRegularExpression in unit test #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace assertRegExp with assertMatchesRegularExpression in unit test #505
Conversation
It's a PITA - the new Looks like it needs some "if method exists" code. I have done that and forced-pushed it. |
63ed94d
to
e11255b
Compare
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
============================================
+ Coverage 98.33% 98.69% +0.35%
Complexity 1757 1757
============================================
Files 67 66 -1
Lines 4328 4279 -49
============================================
- Hits 4256 4223 -33
+ Misses 72 56 -16
Continue to review full report at Codecov.
|
All Travis CI phpunit results now have no warnings/errors. |
These tests seem to get reused in |
e11255b
to
d29010a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thank you
Fixes #507
To avoid:
e.g. https://travis-ci.org/github/sabre-io/dav/jobs/700622019 where the unit test fails in
sabre-io/dav
sabre-io/dav#1275