Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix typos of it's ▶︎ its, where appropriate. #444

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Zearin
Copy link
Contributor

@Zearin Zearin commented Feb 15, 2019

Fix minor typos throughout docstrings.

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #444 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #444   +/-   ##
=========================================
  Coverage     98.87%   98.87%           
  Complexity     1811     1811           
=========================================
  Files            65       65           
  Lines          5168     5168           
=========================================
  Hits           5110     5110           
  Misses           58       58
Impacted Files Coverage Δ Complexity Δ
lib/Parameter.php 99.23% <ø> (ø) 84 <0> (ø) ⬇️
lib/Splitter/ICalendar.php 100% <ø> (ø) 10 <0> (ø) ⬇️
lib/Property.php 98.96% <ø> (ø) 70 <0> (ø) ⬇️
lib/Recur/EventIterator.php 100% <ø> (ø) 46 <0> (ø) ⬇️
lib/Splitter/VCard.php 100% <ø> (ø) 4 <0> (ø) ⬇️
lib/Reader.php 100% <ø> (ø) 3 <0> (ø) ⬇️
lib/FreeBusyGenerator.php 98.16% <ø> (ø) 95 <0> (ø) ⬇️
lib/Component/VCalendar.php 94.93% <ø> (ø) 77 <0> (ø) ⬇️
lib/Parser/MimeDir.php 100% <ø> (ø) 84 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e064da1...401befe. Read the comment docs.

@evert
Copy link
Member

evert commented Feb 15, 2019

This is a dutchism. Still make this mistake often!

@evert
Copy link
Member

evert commented Feb 15, 2019

The prettyCI error seems unrelated, so I think this is good to go.

Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@DeepDiver1975 DeepDiver1975 merged commit 8624ce5 into sabre-io:master Feb 18, 2019
@Zearin
Copy link
Contributor Author

Zearin commented Feb 23, 2019

This is a dutchism. Still make this mistake often!

Native English speakers make this mistake all the time. Don’t feel guilty. 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants