Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed case in e-mail address for ORGANIZER causes exception in Sabre\VObject\ITip\Broker.php #433

Closed
johnkwoods opened this issue Oct 29, 2018 · 1 comment

Comments

@johnkwoods
Copy link
Contributor

We're using sabre/dav 3.22 with sabre/vobject 4.1.6, and we are getting an exception in the parseEventInfo() method of Sabre\VObject\ITip\Broker class. The Exception message is:

"Every instance of the event must have the same organizer."

In the iCal event, this is a recurring meeting, and the original ORGANIZER was First.Last@domain.com. The organizer evidently modified 2 instances. One instance has ORGANIZER as First.Last@domain.com, but the other instance has ORGANIZER as first.last@domain.com.

I believe this issue is due to the following test in parseEventInfo():

if($organizer !== $vevent->ORGANIZER->getNormalizedValue()) {

By adding a few diagnostics into this class, this test is comparing "mailto:First.Last@domain.com" to "mailto:first.last@domain.com", and since they don't match, it throws the exception.

I believe this should be a case-insensitive test. My understanding is that e-mail addresses, themselves, are case-insensitive.

@johnkwoods
Copy link
Contributor Author

Created a pull request for a potential fix:

40287c8

DeepDiver1975 pushed a commit that referenced this issue Oct 30, 2018
Fixes issue where a recurring meeting is created with ORGANIZER as First.Last@domain.com, then individual appointments are saved with ORGANIZER as first.last@domain.com.
DeepDiver1975 added a commit that referenced this issue Oct 30, 2018
staabm pushed a commit that referenced this issue Oct 30, 2018
Fixes issue where a recurring meeting is created with ORGANIZER as First.Last@domain.com, then individual appointments are saved with ORGANIZER as first.last@domain.com.
staabm pushed a commit that referenced this issue Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant