Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add phpstan #431

Merged
merged 2 commits into from Oct 29, 2018
Merged

Feature/add phpstan #431

merged 2 commits into from Oct 29, 2018

Conversation

DeepDiver1975
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #431 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #431      +/-   ##
============================================
+ Coverage     98.87%   98.87%   +<.01%     
- Complexity     1805     1809       +4     
============================================
  Files            65       65              
  Lines          5157     5160       +3     
============================================
+ Hits           5099     5102       +3     
  Misses           58       58
Impacted Files Coverage Δ Complexity Δ
lib/Splitter/ICalendar.php 100% <ø> (ø) 10 <0> (ø) ⬇️
lib/Splitter/VCard.php 100% <ø> (ø) 4 <0> (ø) ⬇️
lib/Property/ICalendar/DateTime.php 100% <ø> (ø) 48 <0> (ø) ⬇️
lib/TimeZoneUtil.php 100% <ø> (ø) 23 <0> (ø) ⬇️
lib/Parser/MimeDir.php 100% <ø> (ø) 84 <0> (ø) ⬇️
lib/Parser/Json.php 96.92% <ø> (ø) 20 <0> (ø) ⬇️
lib/Parser/XML.php 96.96% <ø> (ø) 51 <0> (ø) ⬇️
lib/Writer.php 100% <100%> (ø) 4 <0> (ø) ⬇️
lib/Document.php 100% <100%> (ø) 24 <0> (+4) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18e76a3...9fed1c4. Read the comment docs.

.travis.yml Outdated
- 7.1
- 7.2
- 7.3
- 5.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent

lib/Document.php Outdated
@@ -94,14 +94,18 @@
*/
public function __construct()
{
// public function __construct(Document $root, $name, array $children = [], $defaults = true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug leftover?

@DeepDiver1975
Copy link
Member Author

@staabm mind another look? THX

@DeepDiver1975 DeepDiver1975 merged commit 898b2e7 into master Oct 29, 2018
@DeepDiver1975 DeepDiver1975 deleted the feature/add-phpstan branch October 29, 2018 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants