Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker::processMessageReply #358

Closed
strokyl opened this issue Dec 21, 2016 · 6 comments · Fixed by #652
Closed

Broker::processMessageReply #358

strokyl opened this issue Dec 21, 2016 · 6 comments · Fixed by #652
Labels

Comments

@strokyl
Copy link
Contributor

strokyl commented Dec 21, 2016

Currently, Broker::processMessageReply ignore exceptions that have a recurrent id in a different time-zone than the DTSTART of the master event.
This cause issue in Sabre when a attendee update his partstat on an instance using a client that use UTC for recurrent id.

@strokyl
Copy link
Contributor Author

strokyl commented Dec 21, 2016

I have done a PR : https://github.com/fruux/sabre-vobject/pull/360

@evert
Copy link
Member

evert commented Dec 28, 2016

I'm reasonably certain that RECURRENCE-ID must be in the same timezone as the DTSTART it's referencing, but I've been wrong before.

I'm going to do some digging.

@evert
Copy link
Member

evert commented Dec 28, 2016

I read the relevant section in RFC5545, and I do think that the correct interpretation is that RECURRENCE-ID must be an exact match:

   Value Type:  The default value type is DATE-TIME.  The value type can
      be set to a DATE value type.  This property MUST have the same
      value type as the "DTSTART" property contained within the
      recurring component.  Furthermore, this property MUST be specified
      as a date with local time if and only if the "DTSTART" property
      contained within the recurring component is specified as a date
      with local time.

While it doesn't explicitly say that TZID must be identical, I don't see, logically speaking at least, why that would ever make sense. Thoughts?

@evert evert added the question label Dec 28, 2016
@strokyl
Copy link
Contributor Author

strokyl commented Dec 28, 2016

Furthermore, this property MUST be specified
as a date with local time if and only if the "DTSTART" property
contained within the recurring component is specified as a date
with local time.

This sentence let me think, that if dtstart is not in local time, who can choose what you want as TZID for the recurrent id.
Moreover I think even if this case does not make sense, it's better to support it or if Sabre don't support it the server should reject recurrent with exception having a recurrent id with different TZID from dtstart.
In our frontend for sack of simplicity all recurrent-id are computed in UTC (after thought that probably bad but I think if we did it, other will do it too). So it's better to have a resilient back-end about that.

@gharlan
Copy link
Contributor

gharlan commented May 2, 2024

Google calendar always replies with UTC recurrence-id. Even for existing exception events that were sent to google with a different time zone in dtstart and recurrence-id.

So I think this should be handled in iTip\Broker.

@phil-davis
Copy link
Contributor

The currently proposed solution is in PR #652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants