New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowAccessToNodesWithoutACL - Missing IACLs #1547

Open

bravedave opened this issue Mar 15, 2024 · 1 comment

bravedave commented Mar 15, 2024

I can see this has been discussed before in issue #788, and the code appears to work

But in PHP 8.2: Dynamic Properties are deprecated

the documentation at https://sabre.io/dav/acl/

has an example:

    $aclPlugin = new \Sabre\DAVACL\Plugin();
    $aclPlugin->allowAccessToNodesWithoutACL = false;

allowAccessToNodesWithoutACL is an undefined property

Issue #788 mentions there is another way to do it

Missing IACLs in several nodes - feature propsal #788 (comment) seems to show how to do it

so the question is - what would be the correct way to do it now ?

Member

DeepDiver1975 commented Mar 15, 2024

from the changelog in the original change back in 2016: https://github.com/sabre-io/dav/pull/815/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment