Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to change $disableListing in a config file #1544

Open
faridanoosheh opened this issue Feb 15, 2024 · 1 comment
Open

Access to change $disableListing in a config file #1544

faridanoosheh opened this issue Feb 15, 2024 · 1 comment

Comments

@faridanoosheh
Copy link

faridanoosheh commented Feb 15, 2024

if ($this->disableListing) {

using the Baikal image to run a Caldav Server is really helpful. However, any caldav user will have access to the list of all other users by visiting .../dav.php/ url. As mentioned elsewhere it can be deactivated using disableListing. But for an enduser it would be costly to maintain a project for such a minor change.
I would like to suggest to verify the possibility of getting access to this variable so that it can be modified among the other system variables before running the server like what we have here.

Thanks

@phil-davis
Copy link
Contributor

disableListing is a public property. So code that uses an instantiation of AbstractPrincipalCollection can set the public property.
For example, https://github.com/sabre-io/dav/blob/master/lib/CalDAV/CalendarRoot.php

I suppose that https://github.com/sabre-io/Baikal/blob/master/Core/Frameworks/Baikal/Core/Server.php#L126 initServer can read a setting for disableListing from baikal.yaml and set it straight after doing new \Sabre\CalDAV\CalendarRoot($principalBackend, $calendarBackend)

So I think that Baikal could achieve this without needing to touch sabre/dav code.

Or did I miss something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants