Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve object create/destroy : vcard #1398

Open
mokraemer opened this issue May 25, 2022 · 0 comments
Open

Improve object create/destroy : vcard #1398

mokraemer opened this issue May 25, 2022 · 0 comments

Comments

@mokraemer
Copy link

If you implement Carddav and your storage does not contain the vcard, you create the vcard with
$tmp['carddata']=(\VObject\Component\VCard())->serialize();
Next in Plugin.php the card is unserialized and "converted".

It would be better to allow objects here as well, and do the serialization at this point. If it is required to always check the output format, even it is stored in the db, it would be best, to require carddata to be an VCard object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant