Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure first argument on strpos is a string #1385

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

DeepDiver1975
Copy link
Member

No description provided.

@DeepDiver1975 DeepDiver1975 linked an issue Jan 20, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #1385 (fec8f14) into master (1f9bfa7) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1385      +/-   ##
============================================
- Coverage     97.38%   97.19%   -0.19%     
  Complexity     2826     2826              
============================================
  Files           175      175              
  Lines          8021     8352     +331     
============================================
+ Hits           7811     8118     +307     
- Misses          210      234      +24     
Impacted Files Coverage Δ
lib/DAV/Tree.php 100.00% <100.00%> (ø)
lib/DAV/Xml/Element/Response.php 96.00% <0.00%> (-4.00%) ⬇️
lib/CalDAV/ICSExportPlugin.php 97.22% <0.00%> (-1.36%) ⬇️
lib/DAVACL/Xml/Property/SupportedPrivilegeSet.php 95.23% <0.00%> (-1.32%) ⬇️
lib/DAVACL/Plugin.php 94.11% <0.00%> (-1.17%) ⬇️
lib/CalDAV/SharingPlugin.php 98.38% <0.00%> (-0.74%) ⬇️
lib/DAV/Server.php 96.62% <0.00%> (-0.58%) ⬇️
lib/CalDAV/Plugin.php 97.77% <0.00%> (-0.41%) ⬇️
lib/CardDAV/Plugin.php 96.70% <0.00%> (-0.22%) ⬇️
lib/DAV/Sync/Plugin.php 100.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f9bfa7...fec8f14. Read the comment docs.

@phil-davis
Copy link
Contributor

owncloud/core#39702
PR owncloud/core#39703 has acceptance tests that demonstrate the problem.
Made the same edit as here, to sabre/dav/lib/DAV/Tree.php locally in my ownCloud dev installation, and reran the failing acceptance test and it passes.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception: strpos() expects parameter 1 to be string, int given
3 participants