Fix deprecated usages on PHP 8.1

[cedric-anne]

Fixes following errors encountered on a PHP 8.1 RC environment.

==> Error E_DEPRECATED in ... generated by file /var/glpi/vendor/sabre/dav/lib/DAV/Xml/Element/Response.php on line 124:
ctype_digit(): Argument of type int will be interpreted as string in the future

[cedric-anne]

Hi,

Can anyone review this PR ?

Regards

[cedric-anne]

ping @phil-davis @staabm

[kesselb]

Hey @cedric-anne 👋

please rebase your branch to have a recent CI run.

[cedric-anne]

Hey @cedric-anne wave

please rebase your branch to have a recent CI run.

Hi,

Done.

[codecov]

Codecov Report

Merging #1354 (30f30f7) into master (9c04ba8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1354   +/-   ##
=========================================
  Coverage     97.31%   97.31%           
  Complexity     2806     2806           
=========================================
  Files           174      174           
  Lines          7975     7975           
=========================================
  Hits           7761     7761           
  Misses          214      214           

Impacted Files	Coverage Δ
lib/DAV/Xml/Element/Response.php	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c04ba8...30f30f7. Read the comment docs.

[phil-davis]

Note: issue #1361 - CI is currently failing on various new things found by the latest phpstan. That needs fixing first.

[phil-davis]

A GutHub workflow got:

Error: curl error 7 while downloading https://repo.packagist.org/packages.json: Failed to connect to repo.packagist.org port 443: Connection refused

I will try to rerun it.

[cedric-anne]

Hi @phil-davis

I don't want to force your hand, but PHP 8.1.0 will be released on November 25th. I think a lot of people would like to be able to enjoy a stable release of sabre/dav, including these fixes, by then.

Regards

[phil-davis]

@cedric-anne no problem! I am looking at the other pending PRs that probably can be merged. Whatever happens, I will make a release in the next few days with whatever is merged.