New event "afterCreateCollection" like "afterCreateFile"

[woutersamaey]

No description provided.

[codecov]

Codecov Report

Merging #1341 (759efe8) into master (20d39d0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1341      +/-   ##
============================================
+ Coverage     97.31%   97.35%   +0.03%     
  Complexity     2809     2809              
============================================
  Files           174      174              
  Lines          7975     7976       +1     
============================================
+ Hits           7761     7765       +4     
+ Misses          214      211       -3     

Impacted Files	Coverage Δ
lib/DAV/Server.php	97.19% <100.00%> (+0.60%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d39d0...759efe8. Read the comment docs.

[DeepDiver1975]

Please add tests. THX

[woutersamaey]

@DeepDiver1975 why? and what should I test exactly? It's just an event to hook other stuff on.

[DeepDiver1975]

@DeepDiver1975 why? and what should I test exactly? It's just an event to hook other stuff on.

A test ensures that a specific behavior of the component/system is properly implemented.

Imagine a future refactoring which accidentiallly removes the event being triggered or what so ever.

A test can help to detect such regressions.

[DeepDiver1975]

please see https://github.com/sabre-io/dav/blob/c1afdc77a95efea6ee40c03c45f57c3c0c80ec22/tests/Sabre/DAV/ServerEventsTest.php - THX

[woutersamaey]

Ok that makes sense.

It appears that afterCreateFile also doesn't have a test, so I can't copy/paste that one.

Unfortunately I don't have the time right now to set up the whole thing and make sure it runs.

[DeepDiver1975]

Unfortunately I don't have the time right now to set up the whole thing and make sure it runs.

No prob! Just push the tests as soon as you find the time. THX

[phil-davis]

I added tests.