Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Solscan explorer link #663

Closed
h0lme3 opened this issue Aug 12, 2022 · 6 comments
Closed

Add Solscan explorer link #663

h0lme3 opened this issue Aug 12, 2022 · 6 comments

Comments

@h0lme3
Copy link
Contributor

h0lme3 commented Aug 12, 2022

Hi

solana-contrib is now just providing solana explorer link.
Can we add solscan link?

 generateSolanaExplorerLink(cluster: Cluster = "mainnet-beta"): string {
    return `https://explorer.solana.com/tx/${this.signature}?cluster=${cluster}`;
  }
@h0lme3
Copy link
Contributor Author

h0lme3 commented Aug 12, 2022

resolved by PR #664

@h0lme3
Copy link
Contributor Author

h0lme3 commented Aug 16, 2022

Hi @michaelhly
Do you know when it(sdk) will be published?

@michaelhly
Copy link
Contributor

Publishing now ..

@h0lme3
Copy link
Contributor Author

h0lme3 commented Aug 20, 2022

Hi, I think we need to add generateTXLink() in not only TransactionReceipt but also PendingTransaction
It will be solscan link for pending transaction.

@michaelhly
Copy link
Contributor

Feel free to submit another PR

@h0lme3
Copy link
Contributor Author

h0lme3 commented Aug 20, 2022

Feel free to submit another PR

Added generateTXLink() in PendingTransaction by this PR #675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants