Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Square buttons are not square #2993

Closed
Rattone opened this issue Apr 22, 2024 · 6 comments
Closed

docs: Square buttons are not square #2993

Rattone opened this issue Apr 22, 2024 · 6 comments

Comments

@Rattone
Copy link

Rattone commented Apr 22, 2024

On which page do you see this issue?

https://daisyui.com/components/button/#square-button

Describe the issue

image

Is that normal?

What browsers are you seeing the problem on?

Chrome

Copy link

Thank you @Rattone for reporting issues. It helps daisyUI a lot 💚
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

@sovetski
Copy link

If I am not wrong, it is related to the theme that you selected on the website.

In some themes, border radius are different, I confirm that it's a bit unsettling at first.

@saadeghi
Copy link
Owner

Related:
#2771

Wouldn't it feel weird when all elements of a theme have huge border radius and one button has sharp edges?

@sovetski
Copy link

@saadeghi maybe in this case, perhaps it would be necessary to add more advanced configuration options to allow for more customization? For example, instead of being able to change only radius, we could also change square-radius to be a bit more specific? Because there are already 2 issues from 2 different people, and I was also unsettled by this behavior at first.

Maybe you could also consider adding border configurations in the theme generator here?: Theme Generator

@Rattone
Copy link
Author

Rattone commented Apr 23, 2024

@saadeghi thanks for the reply, I'm not familiar with the library and I didn't realize this theme thing :-)
With a "squared" theme I can have circular buttons but with a rounded theme I can't have square buttons... does that make sense?

@saadeghi
Copy link
Owner

With a "squared" theme I can have circular buttons but with a rounded theme I can't have square buttons... does that make sense?

Yes. It's a common design pattern to use rounded corners occasionally but it's not a common pattern to use a sharp edge square when everything else is circle.
Look at the top right corner of this page (GitHub) and you see one circle button while every other button has less radius.

daisyUI class names are opinionated based on common design patterns but at the end you are free to overwrite everything using utility classes. You can use Tailwind CSS rounded-* utility classes to change the radius as you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants