Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: btn doesn't accept --fallback tokens as first option. #2975

Open
icukovic opened this issue Apr 11, 2024 · 2 comments
Open

bug: btn doesn't accept --fallback tokens as first option. #2975

icukovic opened this issue Apr 11, 2024 · 2 comments

Comments

@icukovic
Copy link

What version of daisyUI are you using?

v4.10.1

Which browsers are you seeing the problem on?

All browsers

Reproduction URL

https://play.tailwindcss.com/XuToYOqkWo

Describe your issue

While playing around with daisyUI I've noticed that the daisyUI Button is not taking --fallback-p CSS token as the the first var() option for background color, due to implementation with token called --btn-color and it always expects --falback-p or --p to be in oklch format

daisyUI src/component/styled/button.css as of today for browsers that support oklch generates:

image

while src/components/styled/badge.css for comparison always accepts --fallback tokens as first and they can be in any type value.
image

Copy link

Thank you @icukovic for reporting issues. It helps daisyUI a lot 💚
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

@icukovic
Copy link
Author

Also I understand that this --btn-color was created to simplify button states recoloring with color-mix function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant