Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: btn-link when button is disabled #2971

Closed
deka opened this issue Apr 10, 2024 · 2 comments
Closed

bug: btn-link when button is disabled #2971

deka opened this issue Apr 10, 2024 · 2 comments

Comments

@deka
Copy link

deka commented Apr 10, 2024

What version of daisyUI are you using?

4.10.1

Which browsers are you seeing the problem on?

Chrome

Reproduction URL

https://play.tailwindcss.com/aw6PHLJHuV

Describe your issue

When button is disabled, btn-link render is same as plain button.

Copy link

Thank you @deka for reporting issues. It helps daisyUI a lot 💚
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

@saadeghi
Copy link
Owner

It's intentional. Not a bug.
Ideally you wouldn't want to disable a button link because the use case for button link is a navigation link, where takes the user to another page. The use case for a disabled button is an action button which we want the action button to exist but its action is prevented temporary.

On top of that, a button styled as a link can't have an ideal disabled visual. Even if we decreasing the opacity, it wouldn't be obvious that it's supposed to be disabled.

Let me know if you have any questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants