Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new OSSRH repository #199

Closed
georgecao opened this issue Mar 18, 2022 · 1 comment · Fixed by #201
Closed

Support new OSSRH repository #199

georgecao opened this issue Mar 18, 2022 · 1 comment · Fixed by #201
Labels
enhancement New feature or request. good first issue Good for newcomers. to grab Ready to do and to grab by those willing.

Comments

@georgecao
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When I use maven-settings-action@2.5.0 in my project to generate settings.xml then to publish libs to Maven Central, as my project depends on another lib I published to the snapshot repository. The maven complains it cannot download it b/c https://s01.oss.sonatype.org/ is not in the repository list.

According to https://central.sonatype.org/publish/publish-guide/#releasing-to-central,

Note: As of February 2021, all new projects began being provisioned on https://s01.oss.sonatype.org/.

so sonatypeSnapshots: true will add https://oss.sonatype.org/ but not the new repo https://s01.oss.sonatype.org/ to the repository list, and they are not same in my experience.

Describe the solution you'd like
I propose a new configuration works like the old sonatypeSnapshots: true, assume we name it ossrhSnapshots: true, to add the new repository url in the list.

There is maybe another way to do it. With the configuration sonatypeSnapshots: true, just add the new repository url to the list, then they both in the list, the only thing need the users to do is to configure the server id.

Describe alternatives you've considered
I tried use a custom settings.xml in my source repo, then use mvn deploy -s ${GITHUB_WORKSPACE}/.github/workflows/settings.xml

Additional context
noop

@slawekjaranowski slawekjaranowski added the enhancement New feature or request. label Mar 18, 2022
@slawekjaranowski
Copy link
Member

I think we can simply add new repo to current list.
So only one file to change https://github.com/s4u/maven-settings-action/blob/master/templates/sonatype-snapshot.xml
and fix tests according to new repo is needed.

PR are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. good first issue Good for newcomers. to grab Ready to do and to grab by those willing.
2 participants