[Feature request] @EqualsAndHashCode Flexibility for rank properties for equal/hashcode method #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samukce
changed the title
|
hello @rspilker , could you take a look at this PR? This improvement would help me given that I use to need to tunning java code and be able to handle those equals configuration through Lombok would be helpful and keep the code clean. |
|
Great job! I love that you've even added a test case, and added you name the the AUTHORS file. |
|
This also opens the door to give primitives as default rank. We could document them to have a default of 1000 for instance. |
|
That sounds promising @rspilker I will see if I can submit some PR with this idea also. |
|
I'm nearly done |
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given some special cases where we need to explicitly order the comparation fields for performance improvement, I have applied the same idea that we have for
@ToString.Include(rank = -1). ie.:@EqualsAndHashCode.Include(rank = -1)Also, there are some discussions related to this here (#1543) about the Equals algorithm and performance. So, given this flexibility can help me with some special cases and I believe that can be helpful for more people too. Let me know what you think folks.