Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Delombok removes explicit this #2444

Closed
mkondratek opened this issue Apr 29, 2020 · 6 comments
Closed

[BUG] Delombok removes explicit this #2444

mkondratek opened this issue Apr 29, 2020 · 6 comments

Comments

@mkondratek
Copy link

Describe the bug
Delombok removes explicit this

To Reproduce
Having a class with methods that contain explicit this, like:
public void updateUI(@UnknownInitialization GitMacheteGraphTable this)
delombok generates code without the explicit this

Expected behavior
Explicit this kept after delombok

Version info (please complete the following information):

  • Lombok from gradle pluginio.freefair.lombok version 5.0.0
  • gradle version 6.3
  • Intellij 2020.1

Additional context
origin issue: freefair/gradle-plugins#217

@rspilker
Copy link
Collaborator

rspilker commented May 7, 2020

Thanks for reporting this. We did recently look into this (no pun intended) when generating code to support the checker framework.

I can reproduce the problem.

@Rawi01
Copy link
Collaborator

Rawi01 commented May 7, 2020

@rspilker I just fixed this one and can provide a pull request if you haven't already fixed it too.

@rspilker
Copy link
Collaborator

rspilker commented May 7, 2020

It was a problem in the pretty printer. We did not print the recvparam field. It was introduced in java8.

@rspilker
Copy link
Collaborator

rspilker commented May 7, 2020

I did fix it and added tests.

@rspilker
Copy link
Collaborator

rspilker commented May 7, 2020

@Rawi01 Thanks for the offer.

@Rawi01
Copy link
Collaborator

Rawi01 commented May 7, 2020

It's fascinating that we managed to fix the same issue at the same time with exactly the same changes 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants