Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better organization of enabled and disabled chips and rename elevated chips. #191

Open
TahaTesser opened this issue Sep 28, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request Themes Playground V8 This issue concerns version 8 and will be addressed in it
Milestone

Comments

@TahaTesser
Copy link
Contributor

TahaTesser commented Sep 28, 2023

The current organisation puts all chips into a single section which makes it challenging to distinguish enabled and disabled chips especially when applying custom colors.

Screenshot 2023-09-28 at 16 18 38

Suggestion

Separate chips like this
Screenshot 2023-09-28 at 16 24 08

@rydmike rydmike added the enhancement New feature or request label Sep 29, 2023
@rydmike rydmike added this to the 7.4.0 milestone Sep 29, 2023
@rydmike
Copy link
Owner

rydmike commented Sep 29, 2023

Have a bunch of theming features to test and add to Chips as well, so this will be a trivial and logical cleanup of Playground UI when working on those features.

The current design is legacy from when a lot widgets shared the same panel and we wanted to fit them in a compact responsive view using a simple Wrap for all of the different Chip variants. Current design allows for this layout much better and changing to it is indeed a good suggestion.

@TahaTesser TahaTesser changed the title Better organisation of enabled and disabled chips and rename elevated chips. Better organization of enabled and disabled chips and rename elevated chips. Oct 12, 2023
@rydmike
Copy link
Owner

rydmike commented Oct 12, 2023

Since it is a very responsive layout, this is the best I can do with Wraps. It will still have a 3 col layout mode in some layout sizes, which is not ideal, but just use a bigger screen and you never see that 😃

With Grid and LayoutBuilder I could do better layout that avoids 3 columns, but I don't think it so necessary for this presentation

Screen.Recording.2023-10-12.at.18.42.52.mov

Q: @TahaTesser what do you mean with rename elevated chips? I'm using the names the Widgets have in Flutter at te moment.


Observation:

I don't think it is still possible to create themes where each chip type Action, Filter, Choice and Input all use from each other different foreground, background colors and disabled color styles, for disabled foreground and background. But I have not checked with all the latest improvements on master channel yet, but last time I looked it was not possible. 😃

rydmike added a commit that referenced this issue Oct 12, 2023
@TahaTesser
Copy link
Contributor Author

Q: @TahaTesser what do you mean with rename elevated chips? I'm using the names the Widgets have in Flutter at te moment.

I was thinking if it could be better to have names like FilterChip and `Elevated FilterChip' to see which ones are elevated.
As the chips blend when you modify elevation, can't disguise which is elevated variant.

@rydmike rydmike added the V7 This issue concerns version 7 and will be addressed in it label Oct 24, 2023
@rydmike rydmike self-assigned this Apr 26, 2024
@rydmike rydmike added V8 This issue concerns version 8 and will be addressed in it and removed V7 This issue concerns version 7 and will be addressed in it labels Apr 26, 2024
@rydmike rydmike modified the milestones: 7.4.0, 8.0.0 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Themes Playground V8 This issue concerns version 8 and will be addressed in it
Projects
Status: Done
Development

No branches or pull requests

2 participants