SSA and generics (go1.18)

[ldez]

Currently, SSA is not working with generics.

So your linter produces a panic when it is used with generics.

There is an issue open about that in the Go repository: golang/go#48525

Inside golangci-lint, we have disabled your linters: golangci/golangci-lint#2649

You have 2 solutions:

• waiting for a version of SSA that will support generics
• dropping the SSA analyzers and using something else to analyze the code.

Related to golang/go#50558

[ldez]

SSA has been updated and it seems to work inside golangci-lint.

[ldez]

in fact, the problem is still here

[ldez]

The code of the linter needs to be adapted to manage generics:

func SqlCloseCheck(db *sql.DB, a int) {
	rows, _ := db.Query("select id from tb") // <- detected OK
	for rows.Next() {

	}
}

func SqlCloseCheckG[T ~int64](db *sql.DB, a T) {
	rows, _ := db.Query("select id from tb") // <- not detected KO
	for rows.Next() {

	}
}

[ldez]

go1.19 will come in about 2 weeks, it can be good if you can fix your linter before this release.

[dolmen]

@ldez For what I see above, it seems that sqlclosecheck works on code that doesn't use generics. Am I right?

So would it be possible to enable sqlclosecheck in golangci-lint to have that feature back, at least to check non-generic code?

[ldez]

you can add the following option to your configuration:

run:
  # ...
  go: go1.17

[ryanrolds]

I believe I've resolved the panic and it's detecting the provided Generics test case. A pre-release has been cut and I will be testing on some personal projects to build confidence.

Thank you for your patience. I will close after building some confidence.