Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Typography component render semantic HTML markup #260

Open
dennismonsewicz opened this issue Feb 27, 2020 · 0 comments
Open

Rework Typography component render semantic HTML markup #260

dennismonsewicz opened this issue Feb 27, 2020 · 0 comments

Comments

@dennismonsewicz
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Inside of the ExpansionPanel component there is the ability to render text and secondary text elements. Each element is currently hard coded as semantic HTML as span tags. It would be nice to simply render the respective Typography component and pass in the local attributes it cares about.

Describe the solution you'd like
I'd like to either A) rebuild the typography component into multiple ones (H1, H2, H3, Span, etc) to support semantic HTML components or B) rebuild the typography component in the interim to render <span> tags instead of <div> elements.

Describe alternatives you've considered
I have simply just modified the ExpansionPanel markup to support the attributes I care about

Additional context
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant