Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors if POMs don't include plugins that poms they attach use #158

Open
NullTerminator opened this issue May 21, 2019 · 0 comments
Open

Comments

@NullTerminator
Copy link
Collaborator

Describe the bug
When a pom attaches another that uses a plugin with Javascript the browser throws errors because the Javascript doesn't get included.

To Reproduce

Voom::Presenters.define(:some_pom) do
  plugin :some_plugin_with_js
end

Voom::Presenters.define(:another) do
  attach :some_pom
end

Render :another in browser and there will be a Javascript undefined error. Currently including the plugin in :another loads the files and clears the error, but this isn't ideal.

Expected behavior
The POM renders clean. JS from atached pom's plugins is included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant