Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning: assuming dim tags are same with different size placeholders - make exception with new behavior version #1141

Open
albertz opened this issue Oct 13, 2022 · 1 comment · May be fixed by #1143
Open

Warning: assuming dim tags are same with different size placeholders - make exception with new behavior version #1141

albertz opened this issue Oct 13, 2022 · 1 comment · May be fixed by #1143
Labels
good first issue Should be a good starting point to get familiar with RETURNN, hopefully not too hard. potential-new-behavior Discussions about RETURNN behaviour

Comments

@albertz
Copy link
Member

albertz commented Oct 13, 2022 •
edited 

          # Note: Instead of making this a warning, we could also enforce this at some point.
          #   The user should be able to fix `extern_data` in the config such that this is correct in the first place.
          #   Also, in addition to this warning, we might want to add some runtime check on the eq of the dyn sizes.
          print(
            "Warning: assuming dim tags are same with different size placeholders: %r vs %r" % (
              self.dyn_size, other_same_base.dyn_size))

This should be an exception instead, not just a warning. For newer setups, this should never be allowed.

This requires a new behavior version (#508).
@albertz albertz added potential-new-behavior Discussions about RETURNN behaviour good first issue Should be a good starting point to get familiar with RETURNN, hopefully not too hard. labels Oct 13, 2022
@albertz albertz mentioned this issue Oct 13, 2022
Closed
@Dark-Rock
Copy link

Hey can I work on this issue?

@Dark-Rock Dark-Rock linked a pull request Oct 13, 2022 that will close this issue
Open
This was referenced Nov 4, 2022
Open
Open
@albertz albertz mentioned this issue Jan 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Should be a good starting point to get familiar with RETURNN, hopefully not too hard. potential-new-behavior Discussions about RETURNN behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change warning for placeholder size to exception Dark-Rock/returnn
2 participants
@albertz @Dark-Rock