Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tokio 1.0 #1451

Closed
incker opened this issue Oct 17, 2020 · 10 comments · Fixed by #1500
Closed

Update to tokio 1.0 #1451

incker opened this issue Oct 17, 2020 · 10 comments · Fixed by #1500
Labels
enhancement A minor feature request

Comments

@incker
Copy link

incker commented Oct 17, 2020

New version of tokio is released
rocket vesrion is 0.2 Cargo.toml

Chance to make breaking changes while rocket = "0.5" not released yet

@SergioBenitez
Copy link
Member

We need hyper to upgrade first. In general, we're aware of new releases and will upgrade as soon as possible.

@krojew
Copy link

krojew commented Oct 19, 2020

You can upgrade now and wrap hyper in a compatibility layer (tokio-compat-02) until they update.

@incker
Copy link
Author

incker commented Oct 19, 2020

Looks like h2 have already received PR, see link
And the only blocker for hyper is h2see link

So, there is no reason to make compatibility layer. Looks like hyper updates will come soon

@protheory8
Copy link

Tokio 0.3 upgrade PR got merged into Hyper master branch recently, waiting for new Hyper release now?

@SergioBenitez
Copy link
Member

@protheory8 That's right.

@jebrosen
Copy link
Collaborator

hyper 0.14.0 has just been released, targeting tokio 1.0 (released earlier today). The other blocker will be tokio-rustls (see tokio-rs/tls#46), and I will likely start tackling a migration PR today or Saturday.

@incker incker changed the title Update to tokio 0.3 Update to tokio 1.0 Dec 24, 2020
@l4l
Copy link

l4l commented Dec 25, 2020

@jebrosen mind if I work on this? Curious to look into the sources.

@jebrosen
Copy link
Collaborator

I already started and (maybe) finished it! - master...jebrosen:tokio1. But I don't think we should review/merge it quite yet, since a decent number of crates don't yet have releases for tokio 1.0. One is reqwest, which I want to be able to run some tests with, and @SergioBenitez has some work in progress on multipart handling that I think will also need a dependency update.

@Absolucy
Copy link

@jebrosen Reqwest already has a PR open: seanmonstar/reqwest#1076

@Absolucy
Copy link

Reqwest has just updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A minor feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants