Dont use const or let, enforce in linter #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this! |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Folks,
I hope I've understood everything right, but I'm hitting an issue on my build of autobahn which uses msgpack5 which uses bl, the recent PR #59 that was released includes the use of
letandconst. Since my build process does not transpilenode_modules(which I've come to understand is typical) I suspected the appropriate fix was to use ES3 syntax instead.If that is correct, then this PR should do just that by removing the usages of
letandconstand enforcing that in the jshint configuration.If that is not correct, please excuse the mistake and if you have advice on how to fix my issue I'd greatly appreciate it.