Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readable-stream@3 #57

Merged
merged 5 commits into from Feb 28, 2019
Merged

readable-stream@3 #57

merged 5 commits into from Feb 28, 2019

Conversation

rvagg
Copy link
Owner

@rvagg rvagg commented Aug 14, 2018

No description provided.

@mcollina
Copy link
Collaborator

readable-stream drops support for Node 4 and 5 (and anything before that).

Also, you might want to remove the custom destroy logic, as it’s already there.

@aduh95
Copy link

aduh95 commented Aug 28, 2018

If Node.js 4 and 5 support is dropped, we can also remove the safe-buffer dependency.

@mcollina
Copy link
Collaborator

+1 to remove safe-buffer

@hugomrdias
Copy link
Contributor

@mcollina anything i can do to move this along ?

@rvagg
Copy link
Owner Author

rvagg commented Feb 28, 2019

lgtm, I guess this is semver-major, @mcollina do you want to cut a release?

@mcollina
Copy link
Collaborator

mcollina commented Feb 28, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants