Fix require() of readable-stream to allow usage of node-core stream

[heri16]

No description provided.

[mcollina]

Unfortunately no. It should be require('readable-stream').Duplex if you want to change this.
This is not really a fallback, but a dependency in the true sense.

[heri16]

Is there a reason for pinning to userland? Were there changes to the Streams API since the oldest nodejs LTS version till current?

Readable-streams library reads whether process.env.READABLE_STREAM has been disabled. Is it safe to set this flag?

[heri16]

I have revised the code to get Duplex from main readable.js .

https://github.com/nodejs/readable-stream/blob/b3cf9b1f46eaa1865930ae03b96d7a4a570746f0/readable.js#L7

This allows the application code to give precedence to core-land stream rather than userland stream.

[mcollina]

There is no need for this. Duplex will always be present in readable-stream.
The reason why this is more stable is that bl inherits from Duplex. If we depended from the one in core, this module would need maintainance/work because of any semver-major changes that land there. By depending on readable-stream, this module became very stable.

[heri16]

Agreed. Enough to just have var DuplexStream = require('readable-stream').Duplex

Instead of the current var DuplexStream = require('readable-stream/duplex')

[mcollina]

Can you please remove require('stream').Duplex?

[heri16]

Yes. Will do so once I get to my laptop

[heri16]

Updated with much thanks.