Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for readUIntLE / readUIntBE / readIntLE / readIntBE #55

Merged
merged 1 commit into from May 15, 2018

Conversation

ctusch
Copy link
Contributor

@ctusch ctusch commented Apr 26, 2018

Implements #54.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have three roads:

  1. do not support this on 0.10, meaning that we do not expose this functions on 0.10.
  2. we bump the major and remove 0.10 support (it’s about time)
  3. we add a userland implementation of the function.

I’m conflicted between 1 and 2. @rvagg what do you think?

@mcollina
Copy link
Collaborator

mcollina commented May 7, 2018

@ctusch can you implement suggestion 1?

@rvagg
Copy link
Owner

rvagg commented May 7, 2018

I think I'm comfortable with 2, we're a long way from 0.10

@mcollina
Copy link
Collaborator

mcollina commented May 7, 2018

Then let's do it! :). What should we support @rvagg? 4+? 6+?

@rvagg
Copy link
Owner

rvagg commented May 15, 2018

@mcollina I'm hearing of a lot of people stuck on 4 .. if we can keep 4 support for a while then it'd be good. As soon as costs us too much then we can ditch it. How's that sound for an approach?

@mcollina
Copy link
Collaborator

I’ll get this out today! +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants