Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change COMMIT_DATE constant #50

Closed
Silverhorn27 opened this issue Feb 25, 2021 · 2 comments
Closed

Change COMMIT_DATE constant #50

Silverhorn27 opened this issue Feb 25, 2021 · 2 comments

Comments

@Silverhorn27
Copy link

Silverhorn27 commented Feb 25, 2021 •
edited

COMMIT_DATE is so awful, will be cool have something like this but with separated time and need to use UTC time.
For example, instead of this need the follow:

  • COMMIT_DATE = 2021-02-11
  • COMMIT_TIME_UTC = 15:05:53
@Silverhorn27 Silverhorn27 changed the title Add GIT_COMMIT_TIME using UTC Change COMMIT_DATE constant Feb 25, 2021
@CraZySacX
Copy link
Member

I think I'm going to change the timestamp handling to allow for both a timestamp version and the version you recommend with the date and time split. I'd also like to be able to allow for UTC vs. Local for both. Right now the build timestamp is UTC only, and the git commit timestamp is the timezone where the user committed from (per git2).

VERGEN_BUILD_DATE
VERGEN_BUILD_TIME
VERGEN_BUILD_TIMESTAMP
VERGEN_GIT_COMMIT_DATE
VERGEN_GIT_COMMIT_TIME
VERGEN_GIT_COMMIT_TIMESTAMP

And you could specify UTC or Local.

@CraZySacX
Copy link
Member

Closed with #52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CraZySacX @Silverhorn27