Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git2: Disable default features #37

Merged
merged 1 commit into from Feb 15, 2021

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Feb 14, 2021

This fixes #36 by disabling the git2 features that rely on openssl-sys, since it looks like we're not actually using any of them in this crate :)

@CraZySacX
Copy link
Member

CraZySacX commented Feb 14, 2021

Can you instead build with cargo build --no-default-features --features build,rustc?

Or in your Cargo.toml
vergen = { version = "4', default-features = false, features = ["build", "rustc"] }

@CraZySacX
Copy link
Member

CraZySacX commented Feb 14, 2021

Yeah I created a new bin project, added vergen as I described above, and openssl-sys is not pulled in. I'd prefer that solution to this PR. Let me know if it doesn't work out for you.

cargo-tree output >
[build-dependencies]
└── vergen v4.0.0
    ├── bitflags v1.2.1
    ├── chrono v0.4.19
    │   ├── libc v0.2.86
    │   ├── num-integer v0.1.44
    │   │   └── num-traits v0.2.14
    │   │       [build-dependencies]
    │   │       └── autocfg v1.0.1
    │   │   [build-dependencies]
    │   │   └── autocfg v1.0.1
    │   ├── num-traits v0.2.14 (*)
    │   └── time v0.1.44
    │       └── libc v0.2.86
    ├── enum-iterator v0.6.0
    │   └── enum-iterator-derive v0.6.0 (proc-macro)
    │       ├── proc-macro2 v1.0.24
    │       │   └── unicode-xid v0.2.1
    │       ├── quote v1.0.9
    │       │   └── proc-macro2 v1.0.24 (*)
    │       └── syn v1.0.60
    │           ├── proc-macro2 v1.0.24 (*)
    │           ├── quote v1.0.9 (*)
    │           └── unicode-xid v0.2.1
    ├── getset v0.1.1 (proc-macro)
    │   ├── proc-macro-error v1.0.4
    │   │   ├── proc-macro-error-attr v1.0.4 (proc-macro)
    │   │   │   ├── proc-macro2 v1.0.24 (*)
    │   │   │   └── quote v1.0.9 (*)
    │   │   │   [build-dependencies]
    │   │   │   └── version_check v0.9.2
    │   │   ├── proc-macro2 v1.0.24 (*)
    │   │   ├── quote v1.0.9 (*)
    │   │   └── syn v1.0.60 (*)
    │   │   [build-dependencies]
    │   │   └── version_check v0.9.2
    │   ├── proc-macro2 v1.0.24 (*)
    │   ├── quote v1.0.9 (*)
    │   └── syn v1.0.60 (*)
    ├── rustc_version v0.3.3
    │   └── semver v0.11.0
    │       └── semver-parser v0.10.2
    │           └── pest v2.1.3
    │               └── ucd-trie v0.1.3
    ├── serde v1.0.123
    └── serde_derive v1.0.123 (proc-macro)
        ├── proc-macro2 v1.0.24 (*)
        ├── quote v1.0.9 (*)
        └── syn v1.0.60 (*)
    [build-dependencies]
    └── chrono v0.4.19 (*)

@Turbo87
Copy link
Contributor Author

Turbo87 commented Feb 15, 2021

unfortunately I specifically need the SHA of the commit for Sentry integration and other things, so disabling the git feature won't work.

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #37 (5e4c3ec) into master (862f1e8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          492       492           
=========================================
  Hits           492       492           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 862f1e8...51f72df. Read the comment docs.

@CraZySacX
Copy link
Member

Ok, I see. You still need the git feature. This will also fix #41.

@CraZySacX CraZySacX merged commit 19bb6ef into rustyhorde:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-compilation fails due to transitive openssl-sys dependency
2 participants