Fix memory reporting with sysinfo 0.16 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysinfo 0.16 changed the units for reporting memory from kilobytes to bytes, this commit updates the reported units to match. I also added TB to the list of possible units. Computers with terabytes of memory do exist nowadays.
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 93.80% 93.82% +0.02%
==========================================
Files 11 11
Lines 1195 1199 +4
==========================================
+ Hits 1121 1125 +4
Misses 74 74
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With commit 6a2e754 when I run "cargo test --all --all-targets --no-default-features --features build,cargo,si" I see
Which correctly reflects the ram in my system.
However with 2bb2b49 and current master I see.
The cause of this is that sysinfo 0.16 changed the units for reporting memory from kilobytes to bytes, this commit updates the reported units to match. I also added TB to the list of possible units. Computers with terabytes of memory do exist nowadays.