Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrono replaced with time, local_offset feature flag added #110

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

jasonozias
Copy link
Collaborator

@jasonozias jasonozias commented Mar 9, 2022

  • chrono has been replace with time as the time crate is better maintained.
  • Added a local_offset feature flag. Using this will enable the local timezone features in the git and build features. However, due to a potential segfault in the time crate, you must also explicitly opt in to the unsoundness by setting RUSTFLAGS="--cfg unsound_local_offset". Per the time crate docs, this is untested, so use with extreme caution.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #110 (f151bf7) into master (e9efb23) will increase coverage by 0.80%.
The diff coverage is 90.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   96.93%   97.73%   +0.80%     
==========================================
  Files          11       11              
  Lines         980      973       -7     
==========================================
+ Hits          950      951       +1     
+ Misses         30       22       -8     
Impacted Files Coverage Δ
src/feature/mod.rs 100.00% <ø> (ø)
src/gen.rs 100.00% <ø> (+1.15%) ⬆️
src/feature/git.rs 86.66% <82.14%> (+0.24%) ⬆️
src/config.rs 100.00% <100.00%> (ø)
src/feature/build.rs 100.00% <100.00%> (+8.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9efb23...f151bf7. Read the comment docs.

@jasonozias jasonozias merged commit 678bb48 into master Mar 9, 2022
@jasonozias jasonozias deleted the feature/chrono-to-time branch March 9, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant