Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple dependencies have critical defects identified by cargo-audit #1338

Open
2 tasks
Teebor-Choka opened this issue Oct 11, 2023 · 1 comment
Open
2 tasks

Comments

@Teebor-Choka
Copy link

Teebor-Choka commented Oct 11, 2023

🐛 Bug description

Some of the dependencies used in wasm-pack should be updated due to critical advisories.

Running cargo audit in a project that uses wasm-pack results in the following advisories issued as errors:

Crate:     rustls-webpki
Version:   0.100.1
Title:     rustls-webpki: CPU denial of service in certificate path building
Date:      2023-08-22
ID:        RUSTSEC-2023-0053
URL:       https://rustsec.org/advisories/RUSTSEC-2023-0053
Severity:  7.5 (high)
Solution:  Upgrade to >=0.100.2, <0.101.0 OR >=0.101.4
Dependency tree:
rustls-webpki 0.100.1
├── webpki-roots 0.23.1
│   └── ureq 2.7.1
│       ├── wasm-pack 0.12.1
...
Crate:     time
Version:   0.1.45
Title:     Potential segfault in the time crate
Date:      2020-11-18
ID:        RUSTSEC-2020-0071
URL:       https://rustsec.org/advisories/RUSTSEC-2020-0071
Severity:  6.2 (medium)
Solution:  Upgrade to >=0.2.23
Dependency tree:
time 0.1.45
└── chrono 0.4.26
    ├── wasm-pack 0.12.1
...
Crate:     atty
Version:   0.2.14
Warning:   unsound
Title:     Potential unaligned read
Date:      2021-07-04
ID:        RUSTSEC-2021-0145
URL:       https://rustsec.org/advisories/RUSTSEC-2021-0145
Dependency tree:
atty 0.2.14
└── wasm-pack 0.12.1

🤔 Expected Behavior

No advisories for dependencies.

👟 Steps to reproduce

Install the cargo audit utility as cargo install cargo-audit and run the audit with cargo audit

🌍 Your environment

Include the relevant details of your environment.
wasm-pack version: wasm-pack 0.12.1
rustc version: rustc 1.72.1 (d5c2e9c34 2023-09-13)

Fix for the issue:

  • Update ureq and chrono dependencies
  • Replace or remove atty dependency
@Teebor-Choka
Copy link
Author

Updating the current ureq dependency to 2.8.0 will fix the advisory:
https://crates.io/crates/ureq/2.8.0/dependencies
https://crates.io/crates/webpki-roots/0.25.2/dependencies

Updating chrono dependencty to 0.4.31 will fix the advisory:
https://crates.io/crates/chrono/0.4.31/dependencies

The atty dependency has not been updated in 4 years and should be considered for a replacement:
https://crates.io/crates/atty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant