Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-pack build fails #58

Open
szunami opened this issue Dec 2, 2020 · 2 comments
Open

wasm-pack build fails #58

szunami opened this issue Dec 2, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@szunami
Copy link

szunami commented Dec 2, 2020

Describe the Bug

I hit what I believe is rustwasm/wasm-pack#886 while working through the Game of Life tutorial. I have pushed my current code state here:

szunami/hello_rust_wasm@50ab356

I am on cargo 1.47.0 (f3c7e066a 2020-08-28), npm 6.4.1, hapy to offer other version as appropriate.

Steps to Reproduce

check out ^ and run wasm-pack build. On my machine I get a very verbose error that includes
[wasm-validator error in module] unexpected true: Exported global cannot be mutable, on global$0.

Notably, running wasm-pack build --dev succeeds.

Expected Behavior

The build should succeed.

Actual Behavior

The build fails.

Additional Context

There are two solutions mentioned in the bug thread:
rustwasm/wasm-pack#886 (comment)
and
rustwasm/wasm-pack#886 (comment)
I think it would be appropriate if one of these solutions came pre-baked into this repository. I am happy to contribute either change.

I recognize that there are some rough edges with respect to WASM, but I think it would be nice if the "hello world" project succeeded consistently. If the solutions in the thread are inappropriate for general adoption, perhaps a new template could be spun up which is more consistent?

@szunami szunami added the bug Something isn't working label Dec 2, 2020
@nguiard
Copy link

nguiard commented Dec 25, 2020

There is a PR proposed for this (#52), I don't if there's a reason it has not been merged. Encountered the same problem following the tutorial.

@szunami
Copy link
Author

szunami commented Dec 25, 2020

I assume it is just busy people doing their best :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants