Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterating over js values #887

Merged
merged 7 commits into from Sep 25, 2018
Merged

Iterating over js values #887

merged 7 commits into from Sep 25, 2018

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Sep 25, 2018

No description provided.

@alexcrichton
Copy link
Contributor

Looks good to me! Do you have an idea for how we will handle the js-sys breaking change? Just publish a new version?

@fitzgen
Copy link
Member Author

fitzgen commented Sep 25, 2018

Do you have an idea for how we will handle the js-sys breaking change? Just publish a new version?

I think we can move js-sys to 0.3.X as well as anything that publicly depends on it (so just wasm-bindgen-futures since web-sys isn't already published, I think).

Will the publish.rs script need to be updated to handle that?

@fitzgen fitzgen merged commit ee0e4bc into rustwasm:master Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton Awaiting requested review from alexcrichton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fitzgen @alexcrichton