New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web-sys: Added Streams API #3065
Conversation
Note that the current diff view is wrt |
Also, it'd be nice if someone could cut a new |
Thanks for being so thorough! I've gone through and removed all the unnecessary
Does this count as a Throw? I don't think it does.
This is also not a throwing function, right? |
No, it doesn't, since marking it
Yes. The returned function could throw, but getting it can't. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just noticed one more thing that I don't think can throw, but after that I think this should be good to merge.
I didn't go through all of them, I just glanced at the ones which weren't duplicated across types (so i.e. not close
, enqueue
etc.)
Thanks again, good catch. Should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your work on this! And sorry about the whole fuss with having to revert.
Builds on revert #3064. This adds the Streams API again, but without the API-breaking
[Throws]
attributes