From 35dbd56f848fdc99608b5ec5173923ee753095d6 Mon Sep 17 00:00:00 2001 From: lshlyapnikov Date: Sun, 8 Sep 2019 18:45:42 -0400 Subject: [PATCH 1/2] making `cargo clippy` happy removing unnessary `drop` calls that clippy reported as errors --- src/module/elements.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/module/elements.rs b/src/module/elements.rs index a758b50e..da65b261 100644 --- a/src/module/elements.rs +++ b/src/module/elements.rs @@ -77,7 +77,6 @@ impl Module { match segment.kind { wasmparser::ElementKind::Passive(ty) => { - drop(ty); bail!("passive element segments not supported yet"); } wasmparser::ElementKind::Active { @@ -222,9 +221,8 @@ impl Emit for ModuleElements { // may want to sort this more intelligently in the future. Otherwise // emitting a segment here is in general much simpler than above as we // know there are no holes. - for (id, segment) in self.arena.iter() { + for (id, _) in self.arena.iter() { cx.indices.push_element(id); - drop((id, segment)); // TODO: sync this with the upstream spec panic!( "encoding a passive element segment requires either \ From 4933959cab6553b9299f61ec69c53f77c9611d4e Mon Sep 17 00:00:00 2001 From: lshlyapnikov Date: Sun, 8 Sep 2019 23:17:21 -0400 Subject: [PATCH 2/2] cleaning up --- src/module/elements.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/module/elements.rs b/src/module/elements.rs index da65b261..8b4ccd2a 100644 --- a/src/module/elements.rs +++ b/src/module/elements.rs @@ -76,7 +76,7 @@ impl Module { let segment = segment?; match segment.kind { - wasmparser::ElementKind::Passive(ty) => { + wasmparser::ElementKind::Passive(_) => { bail!("passive element segments not supported yet"); } wasmparser::ElementKind::Active {