Bump wasmparser + support emitting multiple memories MemArgs #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for re-emitting wasm code that interacts with multiple memories, that is, not the primary (0th) one. Parsing support was already present for reading MemArgs that referred to other memories.
26 tasks
bnjbvr
force-pushed
the
bump-wasmparser
branch
2 times, most recently
from
50af609
to
94389b0
Compare
- Also update spec-tests and wabt to support newer features. - Make it fuzz-safe when features aren't supported.
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit bumps wasmparser. I've made the minimal changes so that it compiles and runs, but most of the new SIMD / exception handling stuff is left to be implemented later.
The second commit allows emitting MemArgs that deals with memories that aren't the primary (0th) memory, by setting the right flag. I've confirmed it works as expected when playing with it in Wasmtime.
Closes #205.