Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wasmparser and pick up new SIMD instructions #185

Merged
merged 3 commits into from Oct 28, 2020
Merged

Update wasmparser and pick up new SIMD instructions #185

merged 3 commits into from Oct 28, 2020

Conversation

alexcrichton
Copy link
Collaborator

No description provided.

@alexcrichton
Update spec tests submodule
a3835e0 
* Remove walrus validation passes since wasmparser covers that now.
* Run reference-types tests now that wabt passes them all.
@alexcrichton
Copy link
Collaborator Author

cc @fitzgen, this removes the last vestiges of wasm validation from walrus since they were a bit out of alignment with the spec on function references anyway. All the validation happens in wasmparser now anyway, so these were a bit redundant and only implemented some validation, not everything with instructions.

fitzgen
fitzgen approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🔥 down the custom validation!

@fitzgen fitzgen merged commit 132bdd6 into rustwasm:master Oct 28, 2020
@alexcrichton alexcrichton deleted the update-wasmparser branch October 28, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexcrichton @fitzgen