Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on wasmparser for validation #173

Merged
merged 1 commit into from Jul 14, 2020

Conversation

alexcrichton
Copy link
Collaborator

This commit removes the type-level validation performed within each
function that walrus previously did. Long-ago in the AST-based IR this
sort of made more sense but nowadays walrus does very little other than
simply validate the input. Recent refactorings in wasmparser are
targeted at reuse of the internal validator, so this commit does exactly
that, reuses wasmparser's validator and removes the type-level
validation in walrus.

This commit removes the type-level validation performed within each
function that walrus previously did. Long-ago in the AST-based IR this
sort of made more sense but nowadays walrus does very little other than
simply validate the input. Recent refactorings in wasmparser are
targeted at reuse of the internal validator, so this commit does exactly
that, reuses wasmparser's validator and removes the type-level
validation in walrus.
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Twice as many deletions as additions :)

@fitzgen fitzgen merged commit e8ef427 into rustwasm:master Jul 14, 2020
@alexcrichton alexcrichton deleted the wasmparser-validator branch July 14, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants