Implement the reference types proposal #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables the `reference-types` and `bulk-memory-operations` proposals from the upstream wasm spec test suite. This involved fully implementing the reference types proposal, notably passive element segments as well as a few table-related instructions. A summary of the changes made here are: * `TableCopy`, `TableInit`, and `ElemDrop` are now all implemented instructions. * All element segments now live as an `Element` type rather than being embedded directly into a `Table`. This is because they all need an index to refer to in `ElemDrop` instructions and such. * Type checking has been updated to handle subtyping * The `Funcref` and `Nullref` value types have been added * Tables now list their element type as a struct field * Elements now participate in GC passes * Global initializers are expanded with `ref.func` and `ref.null`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables the
reference-typesandbulk-memory-operationsproposals from the upstream wasm spec test suite. This involved fully
implementing the reference types proposal, notably passive element
segments as well as a few table-related instructions. A summary of the
changes made here are:
TableCopy,TableInit, andElemDropare now all implemented instructions.Elementtype rather than beingembedded directly into a
Table. This is because they all need anindex to refer to in
ElemDropinstructions and such.FuncrefandNullrefvalue types have been addedref.funcandref.null