Allow custom sections to specify gc roots #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An example PR which consumes this is at bytecodealliance/wasm-interface-types#14 |
fitzgen
approved these changes
Nov 19, 2019
src/module/custom.rs
Outdated
| /// array provided. | ||
| /// | ||
| /// The default provided method does nothing. | ||
| fn gc_add_roots(&self, roots: &mut Roots) { |
There was a problem hiding this comment.
nitpick: let's name this add_gc_roots, since that makes more sense when read out loud in a sentence.
This commit adds APIs necessary to allow custom sections to reference core wasm functions/memories/etc and provide gc roots into them. This is intended to be used, for example, with wasm interface types.
alexcrichton
force-pushed
the
custom-section-roots
branch
from
f8cdb67
to
b494c3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds APIs necessary to allow custom sections to reference
core wasm functions/memories/etc and provide gc roots into them. This is
intended to be used, for example, with wasm interface types.