Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing errors reported by cargo clippy #126

Merged
merged 2 commits into from Sep 9, 2019
Merged

Fixing errors reported by cargo clippy #126

merged 2 commits into from Sep 9, 2019

Conversation

lshlyapnikov
Copy link
Contributor

@lshlyapnikov lshlyapnikov commented Sep 9, 2019 •
edited

removing unnecessary drop calls that clippy reported as errors

See: #125

making cargo clippy happy
35dbd56 
removing unnessary `drop` calls that clippy reported as errors
@lshlyapnikov
Copy link
Contributor Author

@fitzgen please have a look. Does not look like we need to do anything else unless we want to remove the corresponding entries from the underlying collection.

@lshlyapnikov lshlyapnikov changed the title making cargo clippy happy Fixing errors reported by cargo clippy Sep 9, 2019
@alexcrichton
Copy link
Collaborator

Looks great, thanks!

@alexcrichton alexcrichton merged commit ab49687 into rustwasm:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lshlyapnikov @alexcrichton