Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi value! And even more fuzzing! #124

Merged
merged 12 commits into from Sep 5, 2019
Merged

Multi value! And even more fuzzing! #124

merged 12 commits into from Sep 5, 2019

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Aug 29, 2019

fixes #77

@fitzgen
Copy link
Member Author

fitzgen commented Aug 30, 2019

It looks like some change here (probably related to blocks having types or making the types shared) is making the types come out in non-deterministic orders. I'm going to solve this with an explicit sorting step for emitting types.

alexcrichton
alexcrichton reviewed Sep 3, 2019
View reviewed changes
Copy link
Collaborator

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Mind running a few benchmarks to ensure that the usage of Mutex/Arc don't regress our current parsing performance?

I'm also curious, could you explain a bit more where the need for interior mutability arose?

fuzz/fuzz_targets/raw.rs Outdated Show resolved Hide resolved
publish.sh Show resolved Hide resolved
src/module/functions/local_function/mod.rs Show resolved Hide resolved
src/module/types.rs Outdated Show resolved Hide resolved
src/module/types.rs Outdated Show resolved Hide resolved
@fitzgen
Make InstrSeqs hold TypeIds for multi-value
11f09d4 
Instead of holding a couple of `Box<[ValType]>`s for parameters and results, now
they more accurately reflect the spec (and the multi-value extension of it). For
simple, MVP wasm, they hold the optional return value type directly inline. For
multi-value, they reference a `TypeId`. See the `NB` comment above
`InstrSeqType` for details about why this split is beneficial, and we
shouldn't *only* use `TypeId`.
@fitzgen
Add support for multi-value Wasm!
f5d4fc9 
This commit adds support for parsing, emitting, and manipulating multi-value
Wasm!
@fitzgen
Add testing infrastructure for asserting that some Wasm is invalid
fb6a699
@fitzgen
Add a bunch of tests for multi-value
7764ab6
@fitzgen
fuzz: Make the fuzzing infrastructure work with pluggable RNGs
e1ab888 
This will let us define custom RNGs that are controlled via libFuzzer and/or
AFL, so that we can get coverage-guided fuzzing instead of purely random
fuzzing.
@fitzgen
Add support for fuzzing with libFuzzer via cargo fuzz
d52b9f6 
Re-uses basically all of our existing fuzzing infrastructure, but uses libfuzzer
to drive the "RNG" values that we generate Wat with. This lets us combine the
benefits of coverage-guided fuzzing with our existing "structured" fuzzing.
@fitzgen
Run the new cargo fuzz fuzzing infra in CI
f3a23b8
@fitzgen
Slow down the publish script to account for crates.io slowness
5bd08ce
@fitzgen
Sort types deterministically before emitting them
df2403d 
This is not /strictly/ necessary because they are otherwise emitted in the order
that they are added, which is usually the order that they are parsed. However,
if one were adding types in a non-deterministic order, then we would emit types
non-deterministically. Overall, this is just a nice robustness addition.
@fitzgen fitzgen merged commit da63e75 into rustwasm:master Sep 5, 2019
@fitzgen fitzgen deleted the multi-value branch September 5, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multi-value proposal
2 participants
@fitzgen @alexcrichton