Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Chapter 4.6 Debugging" has some unclear explanations #255

Open
MRGRAVITY817 opened this issue Apr 6, 2021 · 0 comments · May be fixed by #267
Open

"Chapter 4.6 Debugging" has some unclear explanations #255

MRGRAVITY817 opened this issue Apr 6, 2021 · 0 comments · May be fixed by #267

Comments

@MRGRAVITY817
Copy link

Where in the docs did you come across this?

  1. In "Add logging to our game of life" section, there's no instruction which to put this code.
#![allow(unused_variables)]
fn main() {
extern crate web_sys;

// A macro to provide `println!(..)`-style syntax for `console.log` logging.
macro_rules! log {
    ( $( $t:tt )* ) => {
        web_sys::console::log_1(&format!( $( $t )* ).into());
    }
}
}
  1. And also this seems like a snippet from git history, which is uneasy to read.
diff --git a/src/lib.rs b/src/lib.rs
index f757641..a30e107 100755
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -123,6 +122,14 @@ impl Universe {
                 let cell = self.cells[idx];
                 let live_neighbors = self.live_neighbor_count(row, col);

+                log!(
+                    "cell[{}, {}] is initially {:?} and has {} live neighbors",
+                    row,
+                    col,
+                    cell,
+                    live_neighbors
+                );
+
                 let next_cell = match (cell, live_neighbors) {
                     // Rule 1: Any live cell with fewer than two live neighbours
                     // dies, as if caused by underpopulation.
@@ -140,6 +147,8 @@ impl Universe {
                     (otherwise, _) => otherwise,
                 };

+                log!("    it becomes {:?}", next_cell);
+
                 next[idx] = next_cell;
             }
         }

How could we improve it?
nitame pushed a commit to nitame/book that referenced this issue Nov 27, 2021
Issue rustwasm#255 - Attempt to make explanation in debugging section…
97a238a 
… better
@nitame nitame linked a pull request Nov 27, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #255 - Attempt to make explanation in debugging section better nitame/book
1 participant
@MRGRAVITY817