Fix the PartialEq impl for quaternions. #814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The double-covering property should only be taken into account for
UnitQuaternion
instead ofQuaternion
itself.As a result we no longer have the blancket impl of
PartialEq
forUnit<T>
. Instead, it is implemented for each specialization ofUnit
. So this is a breaking change.This also simplifies some of the trait bounds required by
Quaternion
for basic implementations likeHash
,PartialEq
,Eq
,Copy
andClone
. That way, we can auto-derive them.