Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advisory entries for futures-rs #454

Closed
Qwaz opened this issue Oct 29, 2020 · 3 comments · Fixed by #460
Closed

Add advisory entries for futures-rs #454

Qwaz opened this issue Oct 29, 2020 · 3 comments · Fixed by #460

Comments

@Qwaz
Copy link
Contributor

Qwaz commented Oct 29, 2020

I recently reported a Send/Sync bound error in futures-rs MappedMutexGuard (rust-lang/futures-rs#2239) and found few more soundness bugs in the futures-rs issue tracker. I don't have enough time to work on advisories for these bugs at the moment, so I'll leave the list here so that someone else can look into them.

@BlackHoleFox
Copy link
Contributor

The PR fixing a Send + Sync trait issue on ArcWake has a comment saying it was only present in pre-production releases and I confirmed that no currently available versions of the crate are available on crates.io missing the Send + Sync implementation on ArcWake. Does an advisory still need to be filed for it? Its been well over a year since.

@Shnatsel
Copy link
Member

No. If it never made it into a release we have no machine-readable way to specify the version range. And anyone using development snapshots already threw caution to the wind, so we might as well not bother.

@Shnatsel
Copy link
Member

@BlackHoleFox thanks for the high-quality advisories! Now that they're merged, I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants