Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches to support newer quick-xml #216

Closed
plugwash opened this issue Dec 22, 2022 · 0 comments · Fixed by #223
Closed

patches to support newer quick-xml #216

plugwash opened this issue Dec 22, 2022 · 0 comments · Fixed by #223

Comments

@plugwash
Copy link

I have just updated quick-xml in Debian and patched xcb accordingly.

Code changes were made to address the following changes in quick-xml 0.23

fix: do not unescape CDATA content because it never escaped by design. CDATA event data now represented by its own BytesCData type (tafia/quick-xml#311)

refactor: now Attributes::next() returns a new type AttrError when attribute parsing failed (Mingun/fast-xml#4)

Code changes were made to address the following changes in quick-xml 0.24

tafia/quick-xml#412: Rename methods of Reader:

tafia/quick-xml#393: Now BytesStart::name() and BytesEnd::name() returns QName, and BytesStart::local_name() and BytesEnd::local_name() returns LocalName

tafia/quick-xml#415: Renamed functions for consistency across the API:

tafia/quick-xml#421: All unescaping functions now accepts and returns strings instead of byte slices

tafia/quick-xml#393: Types of Attribute::key and Attr::key() changed to QName

tafia/quick-xml#412: Change read_to_end* and read_text_into to accept QName instead of AsRef<[u8]>

No code changes were needed for quick-xml 0.25 or 0.26

The patches are available at

https://salsa.debian.org/rust-team/debcargo-conf/-/blob/master/src/xcb/debian/patches/quick-xml-0.23.diff

https://salsa.debian.org/rust-team/debcargo-conf/-/blob/master/src/xcb/debian/patches/quick-xml-0.24.diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant