Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use normal cfg values in examples #3539

Open
madsmtm opened this issue Mar 1, 2024 · 1 comment
Open

Use normal cfg values in examples #3539

madsmtm opened this issue Mar 1, 2024 · 1 comment
Labels
C - needs discussion Direction must be ironed out S - docs Awareness, docs, examples, etc.

Comments

@madsmtm
Copy link
Member

madsmtm commented Mar 1, 2024

We started using cfg_aliases! in #2586, which I guess makes sense from a maintenance perspective (though I'll admit, I'm somewhat against it because it feels like an unnecessary dependency and adds build time).

However, its usage has crept into our examples, which I believe to be a bad idea, as the user will not be having those cfgs, meaning that they cannot directly copy our example code.

So I propose using the normal target_os = "macos"/feature = "x11" values in there.

@madsmtm madsmtm added S - docs Awareness, docs, examples, etc. C - needs discussion Direction must be ironed out labels Mar 1, 2024
@kchibisov
Copy link
Member

I have a plan to remove all the CFGs all together in 0.31.

@kchibisov kchibisov added this to the Version 0.31.0 milestone Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - needs discussion Direction must be ironed out S - docs Awareness, docs, examples, etc.
Development

No branches or pull requests

2 participants